Bad slave naming for manually completed tasks

[nrusch]

This is somewhat minor, but I figured I’d point it out.

If I manually complete a task on a queue that my machine is not a part of, the ‘slave’ name displayed in the Tasks pane is the unqualified name of my machine, rather than the fully-qualified domain name. My machine is not a registered slave in this queue, and is on a different domain than any of the slaves in the queue, so the slave name that is displayed would be misleading or ambiguous, depending on whether a slave with the same name exists in the other queue.

So if my machine name is ws-082.domain-a, the only thing shown in the task list is ws-082, even though there isn’t actually a slave with this name in the queue. And if there were a slave matching that name, it wouldn’t be clear whether the task was completed by ws-082.domain-a or ws-082.domain-b.

Hope this makes sense.

[rrussell]

The reason we use the unqualified name is that its the default name for the slave if you were to launch it on your machine. This way, if your slaves was in the queue, or was added later, then it’s likely that the slave name we chose would be correct.

Cheers,
Ryan